Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discount feature #85

Closed
wants to merge 1 commit into from
Closed

Discount feature #85

wants to merge 1 commit into from

Conversation

saskakol
Copy link

@saskakol saskakol commented Oct 28, 2020

Closes #12

This PR adds discount functionality to invoices. Discounts can be applied either as percentage discounts or simple subtractions from the subtotal. When a discount is applied, a new line will appear under the subtotal indicating the subtracted amount. In the case of percentage discounts the percentage is also displayed on the invoice. Discounts are applied to the entire invoice, and tax is applied after the discount.

@saskakol saskakol marked this pull request as draft October 28, 2020 19:51
@saskakol saskakol marked this pull request as ready for review October 30, 2020 00:42
@saskakol
Copy link
Author

Hey @madisvain, could you label this as hacktoberfest-accepted if you consider it helpful?

@madisvain
Copy link
Owner

@saskakol this is long long overdue but closing this PR for now as Upcount has been re-written with Tauri & React. Discount feature is still standing as a Issue so this feature will definitely get added in the new version.

Issue #12

@madisvain madisvain closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discounts support
2 participants